Added example how to use JsonUnit #33953
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added example how to use JsonUnit.
|
I am not sure if I am supposed to add the example to Spring test or what's expected. Feel free to send suggenstions. |
spring-projects-issues
added
the
status: waiting-for-triage
snicoll
requested changes
Nov 26, 2024
| If you prefer to use another library, you can provide an implementation of | ||
| {spring-framework-api}/test/json/JsonComparator.html[`JsonComparator`]. | ||
|
|
||
| Alternatively, you can use AssertJ https://github.com/assertj/assertj/blob/3.x/assertj-core/src/main/java/org/assertj/core/api/AssertFactory.java[AssertFactory]. |
There was a problem hiding this comment.
Please rephrase that to be consistent with previous sentences. For instance.
JsonUnit is also supported via the standard convertTomethod. I am not keen to start referring to AssertJ's Javadoc for this.
| do this | ||
|
|
||
| ``` | ||
| import static net.javacrumbs.jsonunit.assertj.JsonAssertions.jsonUnitJson; |
There was a problem hiding this comment.
This isn't markdown. We don't compile against JSonUnit so we can't add the example.
snicoll
added
the
status: waiting-for-feedback
|
Closing due to the lack of feedback. |
snicoll
removed
status: waiting-for-feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added example how to use JsonUnit.